refactor(core): 移除 get_file_info 和 list_directory 工具
这些工具功能可通过 bash 命令 (ls, stat, file) 实现,不再需要单独的工具。 删除的文件: - src/tools/filesystem/get_file_info.ts - src/tools/filesystem/list_directory.ts - src/tools/descriptions/filesystem/get_file_info.txt - src/tools/descriptions/filesystem/list_directory.txt - tests/unit/tools/filesystem/get_file_info.test.ts - tests/unit/tools/filesystem/list_directory.test.ts 更新的文件: - src/tools/index.ts: 移除导入和注册 - src/tools/filesystem/index.ts: 移除导出 - src/tools/load_description.ts: 移除映射 - src/agent/presets/*.ts: 移除 tools.enabled 引用 - tests/unit/tools/load_description.test.ts: 移除测试数据
This commit is contained in:
@@ -1,188 +0,0 @@
|
||||
import { describe, it, expect, beforeEach, vi } from 'vitest';
|
||||
|
||||
// Mock fs/promises
|
||||
vi.mock('fs/promises', () => ({
|
||||
stat: vi.fn(),
|
||||
readlink: vi.fn(),
|
||||
readdir: vi.fn(),
|
||||
}));
|
||||
|
||||
// Mock permission manager
|
||||
vi.mock('../../../../src/permission/index.js', () => ({
|
||||
getPermissionManager: vi.fn(() => ({
|
||||
checkFilePermission: vi.fn().mockResolvedValue({
|
||||
allowed: true,
|
||||
action: 'allow',
|
||||
}),
|
||||
})),
|
||||
}));
|
||||
|
||||
// Mock loadDescription
|
||||
vi.mock('../../../../src/tools/load_description.js', () => ({
|
||||
loadDescription: vi.fn(() => '获取文件信息'),
|
||||
}));
|
||||
|
||||
import { getFileInfoTool } from '../../../../src/tools/filesystem/get_file_info.js';
|
||||
import * as fs from 'fs/promises';
|
||||
import { getPermissionManager } from '../../../../src/permission/index.js';
|
||||
|
||||
describe('getFileInfoTool - 获取文件信息工具', () => {
|
||||
const mockStats = {
|
||||
isDirectory: () => false,
|
||||
isFile: () => true,
|
||||
isSymbolicLink: () => false,
|
||||
size: 1024,
|
||||
mode: 0o100644,
|
||||
birthtime: new Date('2024-01-01'),
|
||||
mtime: new Date('2024-01-15'),
|
||||
atime: new Date('2024-01-20'),
|
||||
ino: 12345,
|
||||
nlink: 1,
|
||||
};
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
vi.mocked(fs.stat).mockResolvedValue(mockStats as any);
|
||||
});
|
||||
|
||||
describe('工具定义', () => {
|
||||
it('有正确的名称', () => {
|
||||
expect(getFileInfoTool.name).toBe('get_file_info');
|
||||
});
|
||||
|
||||
it('有正确的元数据', () => {
|
||||
expect(getFileInfoTool.metadata.category).toBe('filesystem');
|
||||
expect(getFileInfoTool.metadata.keywords).toContain('file');
|
||||
expect(getFileInfoTool.metadata.keywords).toContain('info');
|
||||
expect(getFileInfoTool.metadata.keywords).toContain('stat');
|
||||
});
|
||||
|
||||
it('定义了必需的 path 参数', () => {
|
||||
expect(getFileInfoTool.parameters.path.required).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe('execute - 执行', () => {
|
||||
it('成功获取文件信息', async () => {
|
||||
const result = await getFileInfoTool.execute({ path: 'test.txt' });
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(result.output).toContain('路径:');
|
||||
expect(result.output).toContain('类型: 文件');
|
||||
expect(result.output).toContain('大小:');
|
||||
expect(result.output).toContain('权限:');
|
||||
expect(result.output).toContain('创建时间:');
|
||||
expect(result.output).toContain('修改时间:');
|
||||
expect(result.output).toContain('inode:');
|
||||
});
|
||||
|
||||
it('正确显示目录信息', async () => {
|
||||
vi.mocked(fs.stat).mockResolvedValue({
|
||||
...mockStats,
|
||||
isDirectory: () => true,
|
||||
isFile: () => false,
|
||||
} as any);
|
||||
vi.mocked(fs.readdir).mockResolvedValue(['file1', 'file2', 'dir1'] as any);
|
||||
|
||||
const result = await getFileInfoTool.execute({ path: 'test_dir' });
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(result.output).toContain('类型: 目录');
|
||||
expect(result.output).toContain('子项数量: 3');
|
||||
});
|
||||
|
||||
it('正确显示符号链接信息', async () => {
|
||||
vi.mocked(fs.stat).mockResolvedValue({
|
||||
...mockStats,
|
||||
isSymbolicLink: () => true,
|
||||
isFile: () => false,
|
||||
} as any);
|
||||
vi.mocked(fs.readlink).mockResolvedValue('/real/path');
|
||||
|
||||
const result = await getFileInfoTool.execute({ path: 'link' });
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(result.output).toContain('类型: 符号链接');
|
||||
expect(result.output).toContain('链接目标: /real/path');
|
||||
});
|
||||
|
||||
it('正确格式化文件大小', async () => {
|
||||
// 测试不同大小
|
||||
const sizes = [
|
||||
{ size: 500, expected: 'B' },
|
||||
{ size: 1024, expected: 'KB' },
|
||||
{ size: 1024 * 1024, expected: 'MB' },
|
||||
{ size: 1024 * 1024 * 1024, expected: 'GB' },
|
||||
];
|
||||
|
||||
for (const { size, expected } of sizes) {
|
||||
vi.mocked(fs.stat).mockResolvedValue({
|
||||
...mockStats,
|
||||
size,
|
||||
} as any);
|
||||
|
||||
const result = await getFileInfoTool.execute({ path: 'test.txt' });
|
||||
|
||||
expect(result.output).toContain(expected);
|
||||
}
|
||||
});
|
||||
|
||||
it('权限被拒绝时返回错误', async () => {
|
||||
vi.mocked(getPermissionManager).mockReturnValue({
|
||||
checkFilePermission: vi.fn().mockResolvedValue({
|
||||
allowed: false,
|
||||
action: 'deny',
|
||||
reason: '不允许获取信息',
|
||||
}),
|
||||
} as any);
|
||||
|
||||
const result = await getFileInfoTool.execute({ path: '/protected/file' });
|
||||
|
||||
expect(result.success).toBe(false);
|
||||
expect(result.error).toContain('权限被拒绝');
|
||||
});
|
||||
|
||||
it('需要确认时返回提示', async () => {
|
||||
vi.mocked(getPermissionManager).mockReturnValue({
|
||||
checkFilePermission: vi.fn().mockResolvedValue({
|
||||
allowed: false,
|
||||
action: 'ask',
|
||||
needsConfirmation: true,
|
||||
}),
|
||||
} as any);
|
||||
|
||||
const result = await getFileInfoTool.execute({ path: 'file.txt' });
|
||||
|
||||
expect(result.success).toBe(false);
|
||||
expect(result.error).toContain('需要用户确认');
|
||||
});
|
||||
|
||||
it('文件不存在返回错误', async () => {
|
||||
vi.mocked(getPermissionManager).mockReturnValue({
|
||||
checkFilePermission: vi.fn().mockResolvedValue({ allowed: true }),
|
||||
} as any);
|
||||
|
||||
vi.mocked(fs.stat).mockRejectedValue(new Error('ENOENT'));
|
||||
|
||||
const result = await getFileInfoTool.execute({ path: 'nonexistent.txt' });
|
||||
|
||||
expect(result.success).toBe(false);
|
||||
expect(result.error).toContain('ENOENT');
|
||||
});
|
||||
|
||||
it('传递正确参数给权限检查', async () => {
|
||||
const mockCheck = vi.fn().mockResolvedValue({ allowed: true });
|
||||
vi.mocked(getPermissionManager).mockReturnValue({
|
||||
checkFilePermission: mockCheck,
|
||||
} as any);
|
||||
|
||||
await getFileInfoTool.execute({ path: 'test.txt' });
|
||||
|
||||
expect(mockCheck).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
operation: 'info',
|
||||
})
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -1,143 +0,0 @@
|
||||
import { describe, it, expect, beforeEach, vi } from 'vitest';
|
||||
import { listDirTool } from '../../../../src/tools/filesystem/list_directory.js';
|
||||
|
||||
// Mock fs/promises
|
||||
vi.mock('fs/promises', () => ({
|
||||
readdir: vi.fn(),
|
||||
}));
|
||||
|
||||
// Mock permission manager
|
||||
vi.mock('../../../../src/permission/index.js', () => ({
|
||||
getPermissionManager: vi.fn(() => ({
|
||||
checkFilePermission: vi.fn().mockResolvedValue({
|
||||
allowed: true,
|
||||
action: 'allow',
|
||||
}),
|
||||
})),
|
||||
}));
|
||||
|
||||
// Mock loadDescription
|
||||
vi.mock('../../../../src/tools/load_description.js', () => ({
|
||||
loadDescription: vi.fn(() => '列出目录内容'),
|
||||
}));
|
||||
|
||||
import * as fs from 'fs/promises';
|
||||
import { getPermissionManager } from '../../../../src/permission/index.js';
|
||||
|
||||
describe('listDirTool - 列出目录工具', () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
});
|
||||
|
||||
describe('工具定义', () => {
|
||||
it('有正确的名称', () => {
|
||||
expect(listDirTool.name).toBe('list_directory');
|
||||
});
|
||||
|
||||
it('有正确的元数据', () => {
|
||||
expect(listDirTool.metadata.category).toBe('filesystem');
|
||||
expect(listDirTool.metadata.keywords).toContain('list');
|
||||
expect(listDirTool.metadata.keywords).toContain('directory');
|
||||
expect(listDirTool.metadata.keywords).toContain('ls');
|
||||
});
|
||||
|
||||
it('定义了必需的 path 参数', () => {
|
||||
expect(listDirTool.parameters.path).toBeDefined();
|
||||
expect(listDirTool.parameters.path.required).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe('execute - 执行', () => {
|
||||
it('成功列出目录内容', async () => {
|
||||
vi.mocked(fs.readdir).mockResolvedValue([
|
||||
{ name: 'file1.txt', isDirectory: () => false },
|
||||
{ name: 'folder', isDirectory: () => true },
|
||||
{ name: 'file2.js', isDirectory: () => false },
|
||||
] as any);
|
||||
|
||||
const result = await listDirTool.execute({ path: './' });
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(result.output).toContain('file1.txt');
|
||||
expect(result.output).toContain('folder');
|
||||
expect(result.output).toContain('file2.js');
|
||||
});
|
||||
|
||||
it('使用正确的图标区分文件和目录', async () => {
|
||||
vi.mocked(fs.readdir).mockResolvedValue([
|
||||
{ name: 'file.txt', isDirectory: () => false },
|
||||
{ name: 'folder', isDirectory: () => true },
|
||||
] as any);
|
||||
|
||||
const result = await listDirTool.execute({ path: './' });
|
||||
|
||||
expect(result.output).toMatch(/📄.*file\.txt/);
|
||||
expect(result.output).toMatch(/📁.*folder/);
|
||||
});
|
||||
|
||||
it('空目录显示提示', async () => {
|
||||
vi.mocked(fs.readdir).mockResolvedValue([]);
|
||||
|
||||
const result = await listDirTool.execute({ path: './' });
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(result.output).toBe('(空目录)');
|
||||
});
|
||||
|
||||
it('权限被拒绝时返回错误', async () => {
|
||||
vi.mocked(getPermissionManager).mockReturnValue({
|
||||
checkFilePermission: vi.fn().mockResolvedValue({
|
||||
allowed: false,
|
||||
action: 'deny',
|
||||
reason: '不允许列出此目录',
|
||||
}),
|
||||
} as any);
|
||||
|
||||
const result = await listDirTool.execute({ path: '/etc' });
|
||||
|
||||
expect(result.success).toBe(false);
|
||||
expect(result.error).toContain('权限被拒绝');
|
||||
});
|
||||
|
||||
it('需要确认时返回提示', async () => {
|
||||
vi.mocked(getPermissionManager).mockReturnValue({
|
||||
checkFilePermission: vi.fn().mockResolvedValue({
|
||||
allowed: false,
|
||||
action: 'ask',
|
||||
needsConfirmation: true,
|
||||
}),
|
||||
} as any);
|
||||
|
||||
const result = await listDirTool.execute({ path: '/home/user' });
|
||||
|
||||
expect(result.success).toBe(false);
|
||||
expect(result.error).toContain('需要用户确认');
|
||||
});
|
||||
|
||||
it('目录不存在时返回错误', async () => {
|
||||
vi.mocked(getPermissionManager).mockReturnValue({
|
||||
checkFilePermission: vi.fn().mockResolvedValue({
|
||||
allowed: true,
|
||||
action: 'allow',
|
||||
}),
|
||||
} as any);
|
||||
vi.mocked(fs.readdir).mockRejectedValue(new Error('ENOENT: no such directory'));
|
||||
|
||||
const result = await listDirTool.execute({ path: './nonexistent' });
|
||||
|
||||
expect(result.success).toBe(false);
|
||||
expect(result.error).toContain('ENOENT');
|
||||
});
|
||||
|
||||
it('使用 withFileTypes 选项调用 readdir', async () => {
|
||||
vi.mocked(fs.readdir).mockResolvedValue([]);
|
||||
|
||||
await listDirTool.execute({ path: './' });
|
||||
|
||||
expect(fs.readdir).toHaveBeenCalledWith(
|
||||
expect.any(String),
|
||||
{ withFileTypes: true }
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -164,10 +164,8 @@ describe('loadDescription', () => {
|
||||
{ tool: 'read_file', category: 'filesystem' },
|
||||
{ tool: 'write_file', category: 'filesystem' },
|
||||
{ tool: 'edit_file', category: 'filesystem' },
|
||||
{ tool: 'list_directory', category: 'filesystem' },
|
||||
{ tool: 'glob', category: 'filesystem' },
|
||||
{ tool: 'grep', category: 'filesystem' },
|
||||
{ tool: 'get_file_info', category: 'filesystem' },
|
||||
// web
|
||||
{ tool: 'web_search', category: 'web' },
|
||||
{ tool: 'web_extract', category: 'web' },
|
||||
|
||||
Reference in New Issue
Block a user