Add orch command contract tests

This commit is contained in:
2026-03-19 16:45:19 +08:00
parent a20bec1cac
commit 405d8c0aab
8 changed files with 1481 additions and 4 deletions
@@ -0,0 +1,70 @@
# Title
Implement Orch Markdown Test Cases As Automated Tests
## Status
- `completed`
## Owner
- Codex main agent
## Started At
- `2026-03-19`
## Goal
- Add automated `orch` coverage for the command-level cases documented under `docs/tests/orch/`.
- Keep roadmap and implementation status synchronized while the work is in progress.
## Scope
- Add or expand Go tests for currently undocumented automation gaps under `internal/cli/orch/`.
- Update `docs/implementation-roadmap.md` to reflect the broader `orch` automated coverage.
- Update `docs/tests/orch/ROADMAP.md` to reflect the alignment between Markdown cases and automated coverage.
## Checklist
- [x] Review repository instructions, implementation roadmap, and `docs/tests/orch/` case inventory.
- [x] Map Markdown cases to existing `orch` automated coverage and identify missing scenarios.
- [x] Implement missing non-council command tests.
- [x] Implement missing council/report command tests.
- [x] Run targeted and full `orch` test validation.
- [x] Update roadmap documents and archive this execution roadmap.
## Files
- `internal/cli/orch/command_contracts_core_test.go`
- `internal/cli/orch/command_contracts_edges_test.go`
- `internal/cli/orch/command_contracts_remaining_test.go`
- `internal/cli/orch/council_report_contracts_test.go`
- `docs/implementation-roadmap.md`
- `docs/tests/orch/ROADMAP.md`
- `docs/roadmaps/archive/orch-test-case-implementation.md`
## Decisions
- Start from the existing `internal/cli/orch/integration_test.go` suite instead of creating a second parallel harness.
- Use sub-agents with isolated write scopes where practical, while keeping shared roadmap and final integration in the main thread.
- Split the missing coverage into four focused test files:
- `command_contracts_core_test.go` for `run show`, `task add`, and `ready`
- `command_contracts_edges_test.go` for `answer` and `cleanup`
- `command_contracts_remaining_test.go` for the remaining command and workflow gaps
- `council_report_contracts_test.go` for council report edge/default behavior
## Blockers
- none
## Next Step
- none
## Completion Summary
- Added 19 focused `orch` tests across four new test files to close the documented Markdown-case gaps under `docs/tests/orch/`.
- Covered the remaining command contracts for `run init/show`, `task add`, `ready`, `dispatch`, `blocked`, `answer`, `cleanup`, `status`, `reconcile`, and council report edge/default behavior.
- Added explicit workflow coverage for strict-worktree dispatch-to-cleanup and council-review end-to-end.
- Validation passed with `go test ./internal/cli/orch` and `go test ./...`.